This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
cli: enable loading default profiles turnkey #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #933 Signed-off-by: Adam Stokes <[email protected]>
Signed-off-by: Adam Stokes <[email protected]>
Signed-off-by: Adam Stokes <[email protected]>
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 2 |
| Passed | 135 |
| Skipped | 0 |
| Total | 137 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_backend_processes / Un-installing the installed centos agent – Backend Processes - Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_fleet_mode_agent / Un-installing the installed centos agent – Fleet Mode Agent
adam-stokes
commented
Mar 25, 2021
Signed-off-by: Adam Stokes <[email protected]>
mdelapenya
reviewed
Mar 26, 2021
Signed-off-by: Adam Stokes <[email protected]>
mdelapenya
reviewed
Mar 26, 2021
Co-authored-by: Manuel de la Peña <[email protected]>
* fix: use a more comprehensive initialisation method for configs As go init() method is not deterministic, I found that the logger init was not called at the right time. With change we ensure that the Init is: 1) called first 2) existing it the config was already populated * chore: add back traces when extracting the files from the box
mdelapenya
approved these changes
Mar 29, 2021
cachedout
approved these changes
Mar 29, 2021
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
* cli: enable loading default profiles turnkey Fixes #933 * update NOTICE * Fix additional lint issues in ingest_manager_test * Cleanup comment and trace log in GetComposeFile * Provide better trace feedback if missing docker-compose * Update cli/config/config.go * chore: add back traces when extracting the files from the box (#946) * fix: use a more comprehensive initialisation method for configs As go init() method is not deterministic, I found that the logger init was not called at the right time. With change we ensure that the Init is: 1) called first 2) existing it the config was already populated * chore: add back traces when extracting the files from the box Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit ae5b9fe) # Conflicts: # cli/go.mod # cli/go.sum # e2e/_suites/fleet/ingest_manager_test.go
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
* cli: enable loading default profiles turnkey Fixes #933 * update NOTICE * Fix additional lint issues in ingest_manager_test * Cleanup comment and trace log in GetComposeFile * Provide better trace feedback if missing docker-compose * Update cli/config/config.go * chore: add back traces when extracting the files from the box (#946) * fix: use a more comprehensive initialisation method for configs As go init() method is not deterministic, I found that the logger init was not called at the right time. With change we ensure that the Init is: 1) called first 2) existing it the config was already populated * chore: add back traces when extracting the files from the box Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit ae5b9fe) # Conflicts: # cli/go.mod # cli/go.sum # e2e/_suites/fleet/ingest_manager_test.go
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
* cli: enable loading default profiles turnkey Fixes #933 * update NOTICE * Fix additional lint issues in ingest_manager_test * Cleanup comment and trace log in GetComposeFile * Provide better trace feedback if missing docker-compose * Update cli/config/config.go * chore: add back traces when extracting the files from the box (#946) * fix: use a more comprehensive initialisation method for configs As go init() method is not deterministic, I found that the logger init was not called at the right time. With change we ensure that the Init is: 1) called first 2) existing it the config was already populated * chore: add back traces when extracting the files from the box Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit ae5b9fe) # Conflicts: # cli/go.mod # cli/go.sum # e2e/_suites/fleet/ingest_manager_test.go
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 22, 2021
* cli: enable loading default profiles turnkey Fixes elastic#933 * update NOTICE * Fix additional lint issues in ingest_manager_test * Cleanup comment and trace log in GetComposeFile * Provide better trace feedback if missing docker-compose * Update cli/config/config.go * chore: add back traces when extracting the files from the box (elastic#946) * fix: use a more comprehensive initialisation method for configs As go init() method is not deterministic, I found that the logger init was not called at the right time. With change we ensure that the Init is: 1) called first 2) existing it the config was already populated * chore: add back traces when extracting the files from the box Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]>
9 tasks
mdelapenya
added a commit
that referenced
this pull request
Apr 22, 2021
* cli: enable loading default profiles turnkey (#943) * cli: enable loading default profiles turnkey Fixes #933 * update NOTICE * Fix additional lint issues in ingest_manager_test * Cleanup comment and trace log in GetComposeFile * Provide better trace feedback if missing docker-compose * Update cli/config/config.go * chore: add back traces when extracting the files from the box (#946) * fix: use a more comprehensive initialisation method for configs As go init() method is not deterministic, I found that the logger init was not called at the right time. With change we ensure that the Init is: 1) called first 2) existing it the config was already populated * chore: add back traces when extracting the files from the box Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> * Add basic check on correct service is defined for profile runs (#957) Fixes #944 This adds a length check on the string split for verifying that the <service/image name>:<tag> is defined when adding additional services to a profile deployment. Signed-off-by: Adam Stokes <[email protected]> * Update NOTICE (#969) Adds additional overrides to pulling in the proper licenses Signed-off-by: Adam Stokes <[email protected]> * Build binaries via goreleaser (#977) This handles building for all supported architectures including running packr for embedding the binary files. This allows us to easily extend our release process for tagging official cli releases, building in various package formats and publishing to different package registries Signed-off-by: Adam Stokes <[email protected]> * chore: simplify release process on Jenkins (#980) * chore: archive releases in Jenkins UI * chore: simplify release process on Jenkins * chore: remove garbage * chore: support retrying fetching the goreleaser script It will also retry in the case the release command fails * chore: set GITHUB_TOKEN * chore: ensure workspace is clean in the worker * chore: add release information for goreleaser * Remove the agent config file parameters for stand alone (#983) Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> * fix: run unit tests after refactor (#1067) * chore: remove unused files after refactor * chore: run unit tests with new layout * fix: run unit tests on CI * chore: include unit tests for the e2e dir * fix: move unit tests resources for installer tests * fix: move more test resources for unit tests * fix: abstract path calculation from OS Co-authored-by: Adam Stokes <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #933
Signed-off-by: Adam Stokes [email protected]
What does this PR do?
This does a little bit of refactoring of how the profiles are loaded and used. Previously, the packed files were only concerned with locating and accessing a
docker-compose.ymlin the profiles and services. This change allows us to put additional files within the packed binary that may be useful for running profiles and services from the cli. This also forces the cli to utilize the profiles/services after they've been written to disk in the workspace~/.op. The files that are packed by default will always be overwritten meaning any changes to our current set of profiles/services will be the latest within the~/.opworkspace. Custom profiles/services can still be defined by either making a copy of one of the pre-existing profiles/services or creating entirely new directories containing adocker-compose.ymlfile.Why is it important?
In order to have the cli experience mirror what happens in CI it is nice to be able to run the commands just as they would be run in CI, but locally. This change allows us to have the same deployments locally that would be done in CI giving us a more unified experience when writing our BDD tests.
Checklist
make noticein the proper directory)Author's Checklist
How to test this PR locally
To get fleet deployed:
Related issues
Use cases
Screenshots
Logs
Follow-ups